mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.
Date Wed, 21 Feb 2018 13:18:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review197846
-----------------------------------------------------------




3rdparty/CMakeLists.txt
Lines 169-182 (patched)
<https://reviews.apache.org/r/65720/#comment278140>

    Could we generalize this a little bit to whether we are using a multi- or single config
generator (e.g., with `GENERATOR_IS_MULTI_CONFIG` or similar). This should get us some way
to address MESOS-7943.


- Benjamin Bannier


On Feb. 20, 2018, 8:32 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2018, 8:32 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-8599
>     https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), so we replace this
> assumption with a pair of variables `CONFIG_DEBGUG` and
> `CONFIG_RELEASE` which are correct for each generator. This is
> somewhat ugly, but it's the cost of supporting multiple toolsets.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message