mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.
Date Thu, 22 Feb 2018 01:06:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65743/#review198085
-----------------------------------------------------------



Bad patch!

Reviews applied: [65743, 65683]

Failed command: python support/apply-reviews.py -n -r 65683

Error:
2018-02-22 01:06:40 URL:https://reviews.apache.org/r/65683/diff/raw/ [2168/2168] -> "65683.patch"
[1]
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/21723/console

- Mesos Reviewbot


On Feb. 22, 2018, 12:39 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65743/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 12:39 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
> 
> 
> Bugs: MESOS-8575
>     https://issues.apache.org/jira/browse/MESOS-8575
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Because the Docker library did not immediately transition the
> Future returned by `inspect()` to DISCARDED, it was safe for the
> Docker containerizer to discard this Future before failing the
> Promise associated with the Future returned by `launch()`.
> 
> However, the introduction of an `onDiscard` callback in
> `Docker::inspect()` makes this assumption invalid. This patch
> addresses this by failing the Promise before discarding the
> Future.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 7585178f34bdb782f0108d3ab94c23edfacc5564 
> 
> 
> Diff: https://reviews.apache.org/r/65743/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message