mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65615: Added docker constants and common functions file.
Date Thu, 22 Feb 2018 01:47:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/
-----------------------------------------------------------

(Updated Feb. 22, 2018, 1:47 a.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph
Wu.


Changes
-------

Rebased.


Bugs: MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

This patch is in preparation of porting docker tests to Windows. There
were a few hardcoded values that were used throughout the codebase,
such as the `alpine` image, that are defined as a constant in a single
file.


Diffs (updated)
-----

  src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
  src/tests/containerizer/docker_common.hpp PRE-CREATION 
  src/tests/containerizer/docker_containerizer_tests.cpp 97335e197fb0fcb5caa06d8cea4a57277d2cf1f3

  src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 
  src/tests/mesos.hpp 1416682fc8b51d38adc02d549a81fd0b09c83fa9 


Diff: https://reviews.apache.org/r/65615/diff/3/

Changes: https://reviews.apache.org/r/65615/diff/2-3/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message