mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration.
Date Thu, 22 Feb 2018 18:25:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65758/#review198132
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65758]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 22, 2018, 4:25 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65758/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 4:25 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8336
>     https://issues.apache.org/jira/browse/MESOS-8336
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It could happen that an agent re-sends its `RegisterSlaveMessage`
> and with the correct timing, the master would assume that it
> comes from a new agent with the same pid and store its information
> in the registry. See MESOS-8336.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 3705fa7cc3c81a77dc431d5337a7d4a061fa84b9 
> 
> 
> Diff: https://reviews.apache.org/r/65758/diff/1/
> 
> 
> Testing
> -------
> 
> `./mesos-tests --gtest_filter="*AfterReconfiguration*" --gtest_repeat=1000 --gtest_throw_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message