mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.
Date Fri, 23 Feb 2018 11:22:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198172
-----------------------------------------------------------




src/common/protobuf_utils.hpp
Lines 187 (patched)
<https://reviews.apache.org/r/65674/#comment278284>

    Nit: We should document that using `None()` here will create a random UUID. These helper
function currently have the semantic that an `Option<T>` parameter indicated an optional
field in the underlying protobuf. This assumption is broken here. And (not yours) is also
broken in `createOperation` were we should document it as well.


- Jan Schlicht


On Feb. 15, 2018, 3:54 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/slave/slave.cpp c5ec62c0e55e7416d9cd2a49c13459b85e315150 
>   src/tests/operation_status_update_manager_tests.cpp c4429f40e1d7226be59d8ba4283bd91e16799d5a

>   src/tests/resource_provider_manager_tests.cpp c8997ec41fe0c3e02b0f6ab205c9009205c992da

>   src/tests/resource_provider_validation_tests.cpp 9f34c459e24396815f4a785815f83923e276874f

>   src/tests/slave_tests.cpp d2c242eae3169bff3b77770197a36f171cd668ba 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message