mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 65751: Added test fixture for a hung Docker daemon.
Date Fri, 23 Feb 2018 16:35:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65751/#review198184
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5133 (patched)
<https://reviews.apache.org/r/65751/#comment278292>

    `os::write()` is not atomical, so we should write to a temporary file, then rename it:
`mv new_env.tmp test-docker.env`. Otherwise, if someone launches docker cli, while the script
is being updated - `test-docker.sh` might read/import half-written env file.
    
    Probably, we don't need to fix it now.



src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5164-5165 (patched)
<https://reviews.apache.org/r/65751/#comment278291>

    Why do we need `export TEST_DOCKER_ARGUMENTS=$@`?
    
    Let's get rid of `shift 2` command and `ARGS` variable.


- Andrei Budnik


On Feb. 22, 2018, 11:28 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65751/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 11:28 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
> 
> 
> Bugs: MESOS-8591
>     https://issues.apache.org/jira/browse/MESOS-8591
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new `HungDockerTest` class allows test authors to force
> certain Docker daemon calls to be delayed for a specified
> duration.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99

> 
> 
> Diff: https://reviews.apache.org/r/65751/diff/3/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message