mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 65811: Add `path::clean` to stout for normalizing path (for POSIX only now)
Date Tue, 27 Feb 2018 17:42:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review198334
-----------------------------------------------------------




3rdparty/stout/include/stout/path.hpp
Lines 61 (patched)
<https://reviews.apache.org/r/65811/#comment278472>

    Can you clarify whether the rules also apply to windows properly with correct separator?



3rdparty/stout/include/stout/path.hpp
Lines 85 (patched)
<https://reviews.apache.org/r/65811/#comment278475>

    I don't think c++ vector supports negative index (this is not python).
    
    You can use `components.back()` as long as `components` is guaranteed not empty.



3rdparty/stout/include/stout/path.hpp
Lines 99 (patched)
<https://reviews.apache.org/r/65811/#comment278473>

    s/slash/separator in comment



3rdparty/stout/include/stout/path.hpp
Lines 100-101 (patched)
<https://reviews.apache.org/r/65811/#comment278474>

    `components.insert(components.begin(), "");`


- Zhitao Li


On Feb. 27, 2018, 6:23 a.m., Jason Lai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65811/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2018, 6:23 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach,
and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
>     https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add `path::clean` to stout for normalizing path (for POSIX only now)
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp 27438d31617b3b78bf3d4deffd25c93340610e8d 
> 
> 
> Diff: https://reviews.apache.org/r/65811/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Lai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message