mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 65817: Fixed argument quoting in the test script in `HungDockerTest`.
Date Tue, 27 Feb 2018 17:49:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65817/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Gilbert Song, and Greg Mann.


Repository: mesos


Description
-------

Previously, the command arguments for the command `docker $@` was
expanded by an interpreter into a string without quotes. So, a command
`docker run ... -c 'sleep 1'` was expanded into
`docker run ... -c sleep 1`. To fix the issue, `$@` has been wrapped
with double quotes.


Diffs
-----

  src/tests/containerizer/docker_containerizer_tests.cpp 9930580617b188b9c231b002d771e7ba4c61ac52



Diff: https://reviews.apache.org/r/65817/diff/1/


Testing
-------

make check


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message