mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 65759: Added inspect retries to the Docker executor.
Date Wed, 28 Feb 2018 18:05:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65759/
-----------------------------------------------------------

(Updated Feb. 28, 2018, 6:05 p.m.)


Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and Michael Park.


Bugs: MESOS-8574
    https://issues.apache.org/jira/browse/MESOS-8574


Repository: mesos


Description
-------

This patch adds retries for `inspect` command to workaround docker
daemon hangs. We assume that the docker daemon can be temporarily
unresponsive. If it's unresponsive, then any started docker cli
command hangs. To address the issue, we retry `inspect` in the loop.


Diffs (updated)
-----

  src/docker/executor.cpp 93c3e1d1e86814e34cbe5b045f6e61911266c535 


Diff: https://reviews.apache.org/r/65759/diff/6/

Changes: https://reviews.apache.org/r/65759/diff/5-6/


Testing
-------

internal CI

Manually, described in /r/65713


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message