mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65840: Windows: Fixed remaining W* macros in `windows.hpp`.
Date Wed, 28 Feb 2018 19:10:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65840/#review198400
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65839', '65840']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65840

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65840/logs/mesos-tests-stdout.log):

```
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (127 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1178 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (39 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (45 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (85 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2428 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2453 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2575 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2601 ms total)

[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (486138 ms total)
[  PASSED  ] 914 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 211 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65840/logs/mesos-tests-stderr.log):

```
I0228 19:10:05.489377  7064 slave.cpp:3879] Shutting I0228 19:10:04.783398  6664 exec.cpp:162]
Version: 1.6.0
I0228 19:10:04.812382   920 exec.cpp:236] Executor registered on agent 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-S0
I0228 19:10:04.816375   232 executor.cpp:176] Received SUBSCRIBED event
I0228 19:10:04.821398   232 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0228 19:10:04.821398   232 executor.cpp:176] Received LAUNCH event
I0228 19:10:04.826400   232 executor.cpp:648] Starting task a92b0ef1-c792-4f76-bc87-ea2280b8bde6
I0228 19:10:04.909375   232 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I0228 19:10:05.449395   232 executor.cpp:661] Forked command at 3040
I0228 19:10:05.493376  6596 exec.cpp:445] Executor asked to shutdown
I0228 19:10:05.493376   232 executor.cpp:176] Received SHUTDOWN event
I0228 19:10:05.493376   232 executor.cpp:758] Shutting down
I0228 19:10:05.494376   232 executor.cpp:868] Sending SIGTERM to process tree at pid 3down
framework 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-0000
I0228 19:10:05.489377  5492 master.cpp:10258] Updating the state of task a92b0ef1-c792-4f76-bc87-ea2280b8bde6
of framework 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
I0228 19:10:05.490375  7064 slave.cpp:6586] Shutting down executor 'a92b0ef1-c792-4f76-bc87-ea2280b8bde6'
of framework 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-0000 at executor(1)@10.3.1.5:62662
I0228 19:10:05.492377  7064 slave.cpp:922] Agent terminating
W0228 19:10:05.493376  7064 slave.cpp:3875] Ignoring shutdown framework 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-0000
because it is terminating
I0228 19:10:05.495380  5492 master.cpp:10357] Removing task a92b0ef1-c792-4f76-bc87-ea2280b8bde6
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-0000 on agent 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-S0
at slave(398)@10.3.1.5:62641 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 19:10:05.496383  1488 containerizer.cpp:2338] Destroying container 04a7e434-34b1-4688-a572-5a2d5dcb7fc0
in RUNNING state
I0228 19:10:05.497377  1488 containerizer.cpp:2952] Transitioning the state of container 04a7e434-34b1-4688-a572-5a2d5dcb7fc0
from RUNNING to DESTROYING
I0228 19:10:05.498376  1488 launcher.cpp:156] Asked to destroy container 04a7e434-34b1-4688-a572-5a2d5dcb7fc0
I0228 19:10:05.498376  5492 master.cpp:1306] Agent 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-S0
at slave(398)@10.3.1.5:62641 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I0228 19:10:05.498376  5492 master.cpp:3276] Disconnecting agent 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-S0
at slave(398)@10.3.1.5:62641 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 19:10:05.498376  5492 master.cpp:3295] Deactivating agent 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-S0
at slave(398)@10.3.1.5:62641 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0228 19:10:05.500378  7776 hierarchical.cpp:344] Removed framework 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-0000
I0228 19:10:05.501379  7776 hierarchical.cpp:766] Agent 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-S0
deactivated
I0228 19:10:05.603377  7284 containerizer.cpp:2791] Container 04a7e434-34b1-4688-a572-5a2d5dcb7fc0
has exited
I0228 19:10:05.634377  4168 master.cpp:1149] Master terminating
I0228 19:10:05.637377  5492 hierarchical.cpp:609] Removed agent 84a13f3e-8581-4cd6-b054-cddf5a6d8a65-S0
I0228 19:10:06.237380 10060 process.cpp:929] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Feb. 28, 2018, 10:10 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65840/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2018, 10:10 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `WIFEXITED` and `WIFSIGNALED` were incorrectly checking if the
> exit code was not -1 to determine if the process exited or was signaled.
> However, -1 is a valid return code on Windows, so places in the Mesos
> codebase that called `CHECK(WIFEXITED(status)|| WIFSIGNALED(status))`
> would end up aborting the agent or executor.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows.hpp b35e6b94ba6709254450be9429b6f48f2d276689 
> 
> 
> Diff: https://reviews.apache.org/r/65840/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message