mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 65868: Added inspect retries to the docker containerizer in `update` method.
Date Thu, 01 Mar 2018 18:12:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65868/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Greg Mann.


Bugs: MESOS-8605
    https://issues.apache.org/jira/browse/MESOS-8605


Repository: mesos


Description
-------

This patch fixes the bug when a terminal status update is never sent
after termination of the docker executor, when the Docker daemon hangs
for `inspect` command. A terminal status update is postponed until
containerizer `update` completes that uses `inspect` command to get
a PID of the docker container. To address the issue, we retry `inspect`
in the loop.


Diffs
-----

  src/slave/constants.hpp 030fb05186f7f360010bb7e5b4948faac69771cc 
  src/slave/containerizer/docker.cpp 1f4eeb4628517707ab866014fcda9d9b15053d1f 


Diff: https://reviews.apache.org/r/65868/diff/1/


Testing
-------

sudo make check (Fedora 25)
internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message