mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65864: Updated mesos code with the new `os::spawn`.
Date Tue, 06 Mar 2018 21:20:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65864/#review198737
-----------------------------------------------------------


Ship it!




- Andrew Schwartzmeyer


On March 1, 2018, 1:48 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65864/
> -----------------------------------------------------------
> 
> (Updated March 1, 2018, 1:48 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4549
>     https://issues.apache.org/jira/browse/MESOS-4549
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `os::spawn`'s return type was changed from `int` to `Option<int>`, so
> the code in mesos was changed accordingly.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp dae094224321c0974c705023daf076409049de51 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169

>   src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e 
> 
> 
> Diff: https://reviews.apache.org/r/65864/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message