mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65719: Windows: Fixed CMake check of toolset for Ninja.
Date Tue, 06 Mar 2018 23:26:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/#review198746
-----------------------------------------------------------


Ship it!




Ship It!

- Akash Gupta


On March 6, 2018, 8:04 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65719/
> -----------------------------------------------------------
> 
> (Updated March 6, 2018, 8:04 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-8599
>     https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only the Visual Studio generator(s) should check the toolset. The
> Ninja generator requires the environment to be setup in advance, and
> does not have the concept of a toolset, so this warning broke the
> Ninja build.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 
> 
> 
> Diff: https://reviews.apache.org/r/65719/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message