mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65720: Windows: Fixed location of imported libraries for Ninja.
Date Wed, 07 Mar 2018 20:54:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
-----------------------------------------------------------

(Updated March 7, 2018, 12:54 p.m.)


Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.


Changes
-------

Updated per review comments.


Bugs: MESOS-8599
    https://issues.apache.org/jira/browse/MESOS-8599


Repository: mesos


Description
-------

The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), as it is not a
multi-configuration generator. To fix this, we explicitly set the
`IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
when using the Ninja generator on Windows. This does not reuse the
location used on non-Windows platforms, as they're not consistent
despite the generator being the same.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 


Diff: https://reviews.apache.org/r/65720/diff/3/

Changes: https://reviews.apache.org/r/65720/diff/2-3/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message