mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65719: Windows: Fixed CMake configuration for Ninja.
Date Wed, 07 Mar 2018 21:43:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/
-----------------------------------------------------------

(Updated March 7, 2018, 1:43 p.m.)


Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.


Summary (updated)
-----------------

Windows: Fixed CMake configuration for Ninja.


Bugs: MESOS-8599
    https://issues.apache.org/jira/browse/MESOS-8599


Repository: mesos


Description (updated)
-------

Only the Visual Studio generator(s) should check the toolset. The
Ninja generator requires the environment to be setup in advance, and
does not have the concept of a toolset, so this warning broke the
Ninja build.

Instead of warning that we're deprecating some arbitrary generator, we
should just say we don't officially support it so the user knows it
may not work as expected.

Fixed the assumption that all generators on Windows are
multi-configuration. Ninja is single-configuration, so the debug CRT
flag must sometimes be set for `CMAKE_CXX_FLAGS` depending on
`CMAKE_BUILD_TYPE`.


Diffs (updated)
-----

  cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277 


Diff: https://reviews.apache.org/r/65719/diff/3/

Changes: https://reviews.apache.org/r/65719/diff/2-3/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message