mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 65312: Refactored authorization logic in the master.
Date Thu, 08 Mar 2018 12:25:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65312/
-----------------------------------------------------------

(Updated March 8, 2018, 1:25 p.m.)


Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
    https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
-------

This patch makes uses of the new `ObjectApprovers` class which greatly
simplifies the logic for constructing and using authorization.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp 2ef1c9a4c2986e6f254e28387635bc01bb0b3259 
  src/common/protobuf_utils.cpp 9c5fb97afb58f98013b79f3cbaea7dacc3603271 
  src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad 
  src/master/master.hpp c9c8a968b6f56fe261ac9fe374e926a28d40fccb 
  src/master/master.cpp e666b664dd125317cda5d16285d444b9c21e1f35 


Diff: https://reviews.apache.org/r/65312/diff/5/

Changes: https://reviews.apache.org/r/65312/diff/4-5/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message