mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 66022: Based website-related Docker images on ubuntu16.
Date Mon, 12 Mar 2018 11:51:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66022/#review199016
-----------------------------------------------------------


Ship it!





site/Dockerfile
Lines 12 (patched)
<https://reviews.apache.org/r/66022/#comment279303>

    You likely want to add `--no-install-recommends` here as well, right?


- Alexander Rukletsov


On March 10, 2018, 5:49 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66022/
> -----------------------------------------------------------
> 
> (Updated March 10, 2018, 5:49 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We require a recent ruby version in order to build current version of
> native ruby extensions required by the website generator setup.
> 
> Instead of manually installing non-upstream ruby versions with the
> existing centos7-based website images, this patch changes the images
> to be based on ubuntu16 instead which already contains a recent enough
> ruby versions in the upstream repositories.
> 
> We also change the images to reuse the existing mesos-build images
> instead of duplicating the image setup for these parts.
> 
> 
> Diffs
> -----
> 
>   site/Dockerfile 2dd9e288df51b50ce3553045c58be978ce0f3e8e 
>   support/mesos-website/Dockerfile 4156eb4112060332bc62ab14d50a685cc7ee0348 
> 
> 
> Diff: https://reviews.apache.org/r/66022/diff/1/
> 
> 
> Testing
> -------
> 
> Manually built the dev and jenkin images and verified that they contained all required
tools.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message