mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.
Date Thu, 15 Mar 2018 14:27:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66088/
-----------------------------------------------------------

(Updated March 15, 2018, 3:27 p.m.)


Review request for mesos, Benno Evers and Jan Schlicht.


Bugs: MESOS-8677
    https://issues.apache.org/jira/browse/MESOS-8677


Repository: mesos


Description
-------

The method in charge of creating `ObjectApprovers` was relying that
iterating over equivalent hashset's would yield the same order of
results.

While that seemed to be true in different architectures, the macOS
implementation did not follow the same pattern showing a bug in the
code.


Diffs (updated)
-----

  src/common/http.cpp 03f539f8942d50de34f42fd711053e94d0a1c95d 


Diff: https://reviews.apache.org/r/66088/diff/2/

Changes: https://reviews.apache.org/r/66088/diff/1-2/


Testing
-------

```sh
# In multiple platforms.
make check
```


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message