mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66104: Fixed potential memory leak in the `volume/sandbox_path` isolator.
Date Fri, 16 Mar 2018 03:49:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66104/#review199308
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66104]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 15, 2018, 10:31 p.m., Jason Lai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66104/
> -----------------------------------------------------------
> 
> (Updated March 15, 2018, 10:31 p.m.)
> 
> 
> Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, and Zhitao Li.
> 
> 
> Bugs: MESOS-8651
>     https://issues.apache.org/jira/browse/MESOS-8651
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `volume/sandbox_path` isolator inserts a string of the sandbox path
> to its `sandboxes` hashmap instance variable upon the launch of each
> container. However, it never cleans it up properly and can cause
> unbounded growth of the hashmap object, as isolators are global
> singleton objects.
> 
> The patch ensures the sandbox path associated with a given container ID
> gets removed from the `sandboxes` hashmap upon container cleanup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp 20d5b32fb7ada1a17a40bf1a2438db4d85cf1063

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 5801977e93bcb8f463a2635f73e763098f2aa97d

> 
> 
> Diff: https://reviews.apache.org/r/66104/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Lai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message