mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform.
Date Tue, 20 Mar 2018 22:46:30 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 20, 2018, 10:46 p.m.)

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.


Addressed Benjamin's comment and added a move constructor instead.

Summary (updated)

Libprocess: Made tests `GRPCClientTest.*` cross-platform.

Bugs: MESOS-8697

Repository: mesos


The `GRPCClientTest.*` tests now uses in-process channels instead of
Unix domain sockets, except for `DiscardedBeforeServerStarted`, which is
disabled on Windowns for now.

Diffs (updated)

  3rdparty/libprocess/include/process/grpc.hpp edaf0410c62454df53d06957a4a8f1f6027b00bb 
  3rdparty/libprocess/src/tests/grpc_tests.cpp 8bb517fb5659b7010a0fe8b7b90ebb3a5c9f1157 




sudo make check

NOTE: This is not tested on Windows yet. The CMake rules are added later in the chain.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message