mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test.
Date Wed, 21 Mar 2018 13:58:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66177/#review199661
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On March 20, 2018, 6:35 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66177/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 6:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benno Evers.
> 
> 
> Bugs: MESOS-8258
>     https://issues.apache.org/jira/browse/MESOS-8258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test was flaky due to ignoring only TASK_STARTING status update,
> while TASK_RUNNING status update might appear if a task was launched
> before the Docker executor re-registered. To fix the issue, this patch
> ensures that both status updates are received.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 080270281f77fc8732148e69f4d287074c66853e

> 
> 
> Diff: https://reviews.apache.org/r/66177/diff/1/
> 
> 
> Testing
> -------
> 
> ./src/mesos-tests --gtest_filter=DockerContainerizerTest.ROOT_DOCKER_SlaveRecoveryTaskContainer
--gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message