mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 66164: Added to a comment in master.cpp.
Date Wed, 21 Mar 2018 17:21:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66164/#review199675
-----------------------------------------------------------


Ship it!




I felt I had to comment on wording since I'm giving a shipit. All minor though.


src/master/master.cpp
Line 6278 (original), 6278 (patched)
<https://reviews.apache.org/r/66164/#comment280060>

    s/multiple/several
    s/;/:



src/master/master.cpp
Line 6279 (original), 6279-6281 (patched)
<https://reviews.apache.org/r/66164/#comment280061>

    Since these are proper sentences ending with period, it would be nice to capitalize them.


- Alexander Rukletsov


On March 20, 2018, 8:36 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66164/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 8:36 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8463
>     https://issues.apache.org/jira/browse/MESOS-8463
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds an additional example to a comment explaining a seemingly
> duplicate registration attempt of a slave.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 78f16d685328cf203e0d684338a2d8df943c9292 
> 
> 
> Diff: https://reviews.apache.org/r/66164/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message