mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66207: Used native protobuf map in OCI v1 image spec.
Date Thu, 22 Mar 2018 09:00:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66207/#review199745
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66206, 66207]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 22, 2018, 6:59 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66207/
> -----------------------------------------------------------
> 
> (Updated March 22, 2018, 6:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song.
> 
> 
> Bugs: MESOS-8702
>     https://issues.apache.org/jira/browse/MESOS-8702
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used native protobuf map in OCI v1 image spec.
> 
> 
> Diffs
> -----
> 
>   include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d 
>   src/oci/spec.cpp ad5b8bea54e000752c681a9bfd900b25a4158544 
>   src/tests/containerizer/oci_spec_tests.cpp f9a98f635327eb0896f8d9719c8be91e5b5c69d3

> 
> 
> Diff: https://reviews.apache.org/r/66207/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message