mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 63733: Don't print full usage for invocation errors.
Date Fri, 23 Mar 2018 16:21:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63733/#review199894
-----------------------------------------------------------



PASS: Mesos patch 63733 was successfully built and tested.

Reviews applied: `['63733']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63733

- Mesos Reviewbot Windows


On March 23, 2018, 2:39 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63733/
> -----------------------------------------------------------
> 
> (Updated March 23, 2018, 2:39 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Don't print full usage for invocation errors.
> 
> The current usage string for `mesos-master` comes in at 399 lines, and for `mesos-agent`
at 685 lines. Printing such a wall of text will overflow almost any terminal window, making
it necessary to scroll up to see the actual error when invoking mesos with an incorrect command
line.
> 
> 
> Diffs
> -----
> 
>   src/master/main.cpp 3d93fd4825f0f58fce664379e3337a61bb93aa0a 
>   src/slave/main.cpp 67437272ee538dd2eae44f5664630cf7c930c23f 
> 
> 
> Diff: https://reviews.apache.org/r/63733/diff/2/
> 
> 
> Testing
> -------
> 
> Started `mesos-agent` and `mesos-master` with an incorrect command-line.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message