mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 65693: Made the default executor fail kills if the response isn't "200 OK".
Date Mon, 26 Mar 2018 16:01:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65693/#review199974
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp
Lines 1178-1179 (patched)
<https://reviews.apache.org/r/65693/#comment280489>

    Let's also say with which signal.


- Alexander Rukletsov


On March 19, 2018, 4:35 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65693/
> -----------------------------------------------------------
> 
> (Updated March 19, 2018, 4:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8530
>     https://issues.apache.org/jira/browse/MESOS-8530
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default executor's `Future<Nothing> kill(const ContainerID&, int)`
> method returns `Nothing()` if the agent responded to the
> `KILL_NESTED_CONTAINER` call, regardless of the response.
> 
> This patch updates the method, so that it returns a failure if the
> response is not "200 OK".
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 
> 
> 
> Diff: https://reviews.apache.org/r/65693/diff/5/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message