mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 66248: Removed SlaveTest.ChangeDomain.
Date Mon, 26 Mar 2018 16:09:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66248/
-----------------------------------------------------------

(Updated March 26, 2018, 4:09 p.m.)


Review request for mesos and Alexander Rukletsov.


Summary (updated)
-----------------

Removed SlaveTest.ChangeDomain.


Bugs: MESOS-8711
    https://issues.apache.org/jira/browse/MESOS-8711


Repository: mesos


Description (updated)
-------

This test was originally written with the assumption that the
would give get a new agent id after receiving a Shutdown
message from the master.

When that behaviour was changed, the test was disabled since
the agent could not reuse the previous agent id when a fault
domain was added.

With the introduction of reconfiguration policies, this feature
is now tested by SlaveTest.ReconfigurationPolicy, making this test
obsolete.


Diffs (updated)
-----

  src/tests/slave_tests.cpp 028cd32c7043eba4e6f2045956471bd0bf42371c 


Diff: https://reviews.apache.org/r/66248/diff/2/

Changes: https://reviews.apache.org/r/66248/diff/1-2/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message