mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66289: Added fields to GET_STATE necessary for streaming Web UI.
Date Tue, 27 Mar 2018 01:51:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66289/#review200014
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66289]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 27, 2018, 12:10 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66289/
> -----------------------------------------------------------
> 
> (Updated March 27, 2018, 12:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added fields to GET_STATE necessary for streaming Web UI.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 10dcac83fa70da5760a5c231665d7498cc168622 
>   include/mesos/master/master.proto aa63904a33290a3beda162bbc9f44b56ab04a1e7 
>   include/mesos/v1/master/master.proto ddb28f96b2a3a439bb9a829995a9a3015f65ba43 
>   src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
> 
> 
> Diff: https://reviews.apache.org/r/66289/diff/1/
> 
> 
> Testing
> -------
> 
> This is an updated version of https://github.com/benh/mesos/commit/c3ce5edb35e10e682f7d791719ad077f78b1dc95.
> 
> I have applied a `make check` + run a master locally and done a `curl -d '{"type":"GET_STATE"}'
-H "Content-Type: application/json" -X POST http://localhost:5061/api/v1` to check the JSON
returned:
> ```
> {
>     "type": "GET_STATE",
>     "get_state": {
>         "get_tasks": {},
>         "get_executors": {},
>         "get_frameworks": {},
>         "get_agents": {},
>         "version": "1.6.0",
>         "build_time": {
>             "nanoseconds": 1522071419000000000
>         },
>         "build_user": "agrillet",
>         "start_time": {
>             "nanoseconds": 1522078049371355904
>         },
>         "leader": {
>             "id": "1ce9804a-efd6-422a-8669-ce82e4183173",
>             "ip": 3492307904,
>             "port": 5061,
>             "pid": "master@192.99.40.208:5061",
>             "hostname": "gru1.hw.ca1.mesosphere.com",
>             "version": "1.6.0",
>             "address": {
>                 "hostname": "gru1.hw.ca1.mesosphere.com",
>                 "ip": "192.99.40.208",
>                 "port": 5061
>             },
>             "capabilities": [
>                 {
>                     "type": "AGENT_UPDATE"
>                 }
>             ]
>         },
>         "elected_time": {
>             "nanoseconds": 1522078049390997760
>         }
>     }
> }
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message