mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66050: Implemented grow and shrink of persistent volumes.
Date Tue, 27 Mar 2018 06:30:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/
-----------------------------------------------------------

(Updated March 26, 2018, 11:30 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
-------

Chun's review comments.


Bugs: MESOS-4965
    https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
-------

The new offer operations are implemented as non-speculative operations,
which means they cannot be chained with previous offer operations which
depend on results of each other.


Diffs (updated)
-----

  src/common/protobuf_utils.cpp 2acdc798200e82d14651b1edcc5f83e174477d53 
  src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
  src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45 
  src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
  src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 
  src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
  src/tests/mesos.hpp 01fd1c2bf21ef96dbab0769a1c1c92d7e3b60032 
  src/tests/persistent_volume_tests.cpp 924d8458e54e34a49c99593482b5908c5f7c7a48 
  src/tests/reservation_tests.cpp 8d8e9c8390e65187269bd194bb322bbdff88e0bd 


Diff: https://reviews.apache.org/r/66050/diff/6/

Changes: https://reviews.apache.org/r/66050/diff/5-6/


Testing
-------


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message