mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66050: Implemented grow and shrink of persistent volumes.
Date Tue, 27 Mar 2018 07:23:03 GMT


> On March 27, 2018, 6:32 a.m., Zhitao Li wrote:
> > src/slave/slave.cpp
> > Lines 8053-8059 (patched)
> > <https://reviews.apache.org/r/66050/diff/5/?file=1985839#file1985839line8056>
> >
> >     Sorry I'm not following this comment.
> >     
> >     From what I can read, the sequence here is:
> >     
> >     ```
> >     Slave::addOperation();
> >     calculate converted resources;
> >     UpdateOperationStatusMessage update = generate OperationStatus;
> >     Slave::updateOperation();
> >       - Slave::apply(...) // which performs checkpointing
> >     send(master.get(), update); // actually sending to master
> >     ```
> >     so when we send the `UpdateOperationStatusMessage` to master, Slave::apply()
should already be called.
> >     
> >     Am I missing something?

Oops. Sorry I read the patch wrong. So you moved the checkpointing logic into `Slave::apply()`,
which should be OK, just that we'll do extra checkpoints when processing operations related
to RP resources. Probably still worth thinking if the code can be further simpilified with
some refactoring.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/#review199818
-----------------------------------------------------------


On March 27, 2018, 6:30 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66050/
> -----------------------------------------------------------
> 
> (Updated March 27, 2018, 6:30 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new offer operations are implemented as non-speculative operations,
> which means they cannot be chained with previous offer operations which
> depend on results of each other.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 2acdc798200e82d14651b1edcc5f83e174477d53 
>   src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
>   src/master/master.cpp 20692c36c021fdae91de0b156f26fc56cf7c4f45 
>   src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
>   src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 
>   src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
>   src/tests/mesos.hpp 01fd1c2bf21ef96dbab0769a1c1c92d7e3b60032 
>   src/tests/persistent_volume_tests.cpp 924d8458e54e34a49c99593482b5908c5f7c7a48 
>   src/tests/reservation_tests.cpp 8d8e9c8390e65187269bd194bb322bbdff88e0bd 
> 
> 
> Diff: https://reviews.apache.org/r/66050/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message