mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 66292: Validated that all tasks in the same group have same max_duration.
Date Tue, 27 Mar 2018 21:07:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66292/#review200070
-----------------------------------------------------------



What's the rationale for this? A common use of task groups is to specify sidecars for a primary
task container, in which case it is most natural to have the `max_duration` only on the task
container.

- James Peach


On March 26, 2018, 9:49 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66292/
> -----------------------------------------------------------
> 
> (Updated March 26, 2018, 9:49 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
>     https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Validated that all tasks in the same group have same max_duration.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 
> 
> 
> Diff: https://reviews.apache.org/r/66292/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message