mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 66307: Added implicit conversion from nullptr to Owned and Shared.
Date Tue, 27 Mar 2018 22:00:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66307/#review200074
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On March 27, 2018, 3:34 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66307/
> -----------------------------------------------------------
> 
> (Updated March 27, 2018, 3:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To communicate absence of a reference we usually use `nullptr` inside
> smart pointers. This patch adds smart pointer constructors from
> `nullptr_t` which mirror conversion present in `std::unique_ptr` and
> `std::shared_ptr` simplifying such use cases.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/owned.hpp cc149e78165d42f1243168c34fc64fd121c6c83f

>   3rdparty/libprocess/include/process/shared.hpp 6eb69439d21897398157b2d400a00c49ea720e68

> 
> 
> Diff: https://reviews.apache.org/r/66307/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message