mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66330: Added 'OPENSSL_INCLUDE_DIR' to forwarded arguments.
Date Wed, 28 Mar 2018 12:51:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66330/#review200106
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66330]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 28, 2018, 2:01 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66330/
> -----------------------------------------------------------
> 
> (Updated March 28, 2018, 2:01 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To help third-party dependencies find and build with OpenSSL, certain
> options are forwarded to them. Dependencies using the 'FindOpenSSL'
> module need either 'OPENSSL_ROOT_DIR' or 'OPENSSL_INCLUDE_DIR' to figure
> out the location of OpenSSL. In the module 'OPENSSL_ROOT_DIR' acts as a
> hint for 'OPENSSL_INCLUDE_DIR'. I.e., 'OPENSSL_INCLUDE_DIR' will be set
> by the module. As a consequence, if 'OPENSSL_ROOT_DIR' is not configured
> in 'ccmake', users will only be prompted to provide
> 'OPENSSL_INCLUDE_DIR'. By forwarding 'OPENSSL_INCLUDE_DIR' we cover this
> case for third-party dependencies, thus allowing users to configure the
> project in 'ccmake' without having to explicitly set 'OPENSSL_ROOT_DIR'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2b63b58f7d6a88c9986b746283dcfa79b7bcb270 
> 
> 
> Diff: https://reviews.apache.org/r/66330/diff/2/
> 
> 
> Testing
> -------
> 
> On macOS 10.13.3 with OpenSSL installed via Homebrew:
> 
> $ mkdir build && cd build
> $ ccmake -GNinja ..
> 
> * Press "c" to configure.
> * Switch on "ENABLE_LIBEVENT" and "ENABLE_SSL".
> * Press "c" to configure. There will be an error explaining that 'OPENSSL_ROOT_DIR' or
'OPENSSL_INCLUDE_DIR' is missing.
> * `ccmake` will ask for "OPENSSL_INCLUDE_DIR", set it to `/usr/local/opt/openssl/include`
(assuming `$(brew --prefix) == /usr/local`)
> * Press "c" to configure again. There shouldn't be an error now.
> * Press "g" to generate the configuration.
> 
> $ ninja
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message