mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 66309: Externalize creation of resource provider manager backing storage.
Date Wed, 28 Mar 2018 13:30:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66309/#review200105
-----------------------------------------------------------




src/resource_provider/registrar.hpp
Lines 28 (patched)
<https://reviews.apache.org/r/66309/#comment280752>

    Include this below `<memory>` and above `<process/future.hpp`.



src/resource_provider/registrar.hpp
Line 67 (original), 69 (patched)
<https://reviews.apache.org/r/66309/#comment280753>

    Delete `master's`.



src/resource_provider/registrar.hpp
Lines 68-69 (original), 70-71 (patched)
<https://reviews.apache.org/r/66309/#comment280754>

    I don't like the semantics of this:
    A `state::Storage` doesn't provide any information if it belongs to master or agent but
we instantiate an `AgentRegistrar` anyways.
    
    Hence, please rename `AgentRegistrar` to something more general that indicates that this
isn't tied to an agent state.



src/resource_provider/registrar.hpp
Line 110 (original), 111 (patched)
<https://reviews.apache.org/r/66309/#comment280755>

    Please rename, see above.


- Jan Schlicht


On March 27, 2018, 5:34 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66309/
> -----------------------------------------------------------
> 
> (Updated March 27, 2018, 5:34 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8735
>     https://issues.apache.org/jira/browse/MESOS-8735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes the way the storage backing an agent's resource
> provider registrar is created: while before we created it implicitly
> when constructing the registrar, we now consume storage passed on
> construction.
> 
> Being able to explicitly inject the used storage simplifies testing.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
>   src/resource_provider/registrar.cpp 9eb49f1327a0b598c5464a29a09ee286d7018f09 
>   src/tests/resource_provider_manager_tests.cpp d947bd037190e6b7ea7b2277b5fbe47816878de4

> 
> 
> Diff: https://reviews.apache.org/r/66309/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message