mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 66331: Fixed test to assert precondition.
Date Wed, 28 Mar 2018 14:21:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66331/
-----------------------------------------------------------

Review request for mesos and Jan Schlicht.


Repository: mesos


Description
-------

This patch changes an assert in
`ResourceProviderManagerHttpApiTest.UpdateOperationStatus` to make
sure a received message has the correct type. We later assume a
certain type which could and not aborting the test if an unexpected
message type is received would lead to hard runtime failures like
segmentation faults.


Diffs
-----

  src/tests/resource_provider_manager_tests.cpp d947bd037190e6b7ea7b2277b5fbe47816878de4 


Diff: https://reviews.apache.org/r/66331/diff/1/


Testing
-------


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message