mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66344: Supported non-speculative operations on agent default resources.
Date Wed, 28 Mar 2018 23:04:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66344/#review200143
-----------------------------------------------------------




src/slave/slave.cpp
Line 4311 (original), 4308 (patched)
<https://reviews.apache.org/r/66344/#comment280798>

    s/Calculated/Calculate/



src/slave/slave.cpp
Lines 4314 (patched)
<https://reviews.apache.org/r/66344/#comment280799>

    Perhaps we should leave a comment here explaining the validity of this CHECK? Something
like "Operation validation guarantees that we can generate resource conversions from all operations
on agent default resources."
    
    Currently, we rely on the fact that operations like CREATE_VOLUME (which cannot be used
to generate resource conversions) are invalidated if they have a resource provider ID set.
It might be nice to validate this case more explicitly in the future, but since we have separate
validation functions for each operation type that would be cumbersome right now.



src/slave/slave.cpp
Lines 4321-4323 (patched)
<https://reviews.apache.org/r/66344/#comment280796>

    Indented too far.



src/slave/slave.cpp
Lines 4339 (patched)
<https://reviews.apache.org/r/66344/#comment280800>

    s/updateOperation/`updateOperation`/
    s/operation/operations/


- Greg Mann


On March 28, 2018, 9:41 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66344/
> -----------------------------------------------------------
> 
> (Updated March 28, 2018, 9:41 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We use `getResourceConversions` to calculate `conversions`,
> apply that to agent default resources if not on resource provider,
> and send `UpdateOperationStatusMessage` message back to master.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
> 
> 
> Diff: https://reviews.apache.org/r/66344/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message