mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66325: Implemented idempotency for agent resource provider config API calls.
Date Thu, 29 Mar 2018 02:10:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66325/
-----------------------------------------------------------

(Updated March 29, 2018, 2:10 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.


Changes
-------

Addressed Jie's comment.


Bugs: MESOS-8742
    https://issues.apache.org/jira/browse/MESOS-8742


Repository: mesos


Description
-------

`ADD_RESOURCE_PROVIDER_CONFIG`, `UPDATE_RESOURCE_PROVIDER_CONFIG` and
`REMOVE_RESOURCE_PROVIDER_CONFIG` now return 200 for identical
repetivite calls.


Diffs (updated)
-----

  src/resource_provider/daemon.hpp a6d0013fa3645fd2b705351a86679f7fba13e7e3 
  src/resource_provider/daemon.cpp d0a8186da80a1bffbb71f524e639bc7d75ef6243 
  src/resource_provider/storage/provider.cpp 8db1ce0589be2885cd970f029027fb73c5cbc09f 
  src/slave/http.cpp 65081c95c888a8236aafdfc627a7aa4e9a72b65d 


Diff: https://reviews.apache.org/r/66325/diff/3/

Changes: https://reviews.apache.org/r/66325/diff/2-3/


Testing
-------

make

NOTE: Test `*/AgentResourceProviderConfigApiTest.RemoveNotFound` won't pass since the semantics
of `REMOVE_RESOURCE_PROVIDER_CONFIG` is changed.
Tests are added in the next patch.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message