mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66362: Fixed use of const reference for storing an rvalue in a test.
Date Thu, 29 Mar 2018 18:45:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66362/#review200207
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66362]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 29, 2018, 5:17 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66362/
> -----------------------------------------------------------
> 
> (Updated March 29, 2018, 5:17 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed use of const reference for storing an rvalue in a test.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 98b697d8f8f249b801f960dab9cef5958f920302

> 
> 
> Diff: https://reviews.apache.org/r/66362/diff/1/
> 
> 
> Testing
> -------
> 
> Tests passed on Mesosphere's internal CI.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message