mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 66371: Temporarily disabled CSI proto compilation in CMake.
Date Thu, 29 Mar 2018 23:58:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66371/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, David Forsythe, and Jan Schlicht.


Bugs: MESOS-8749
    https://issues.apache.org/jira/browse/MESOS-8749


Repository: mesos


Description
-------

The `major` and `minor` macros defined on some systems conflict with
field names in the CSI v0.1.0 spec proto. Temporarily disable it in
CMake until CSI is bumped to 0.2.


Diffs
-----

  src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e 


Diff: https://reviews.apache.org/r/66371/diff/1/


Testing
-------

`make check` with CMake


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message