mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66365: Fixed generation of operation statuses in `Slave::applyOperation()`.
Date Fri, 30 Mar 2018 15:38:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66365/#review200239
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp
Lines 4266-4268 (patched)
<https://reviews.apache.org/r/66365/#comment280893>

    Was this formatting produced by clang-format?
    
    I would probably do:
    ```
      Option<OperationID> operationId =
        message.operation_info().has_id()
          ? message.operation_info().id()
          : Option<OperationID>::none();
    ```
    but if clang-format generated this, then let's just keep it.


- Greg Mann


On March 29, 2018, 5:19 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66365/
> -----------------------------------------------------------
> 
> (Updated March 29, 2018, 5:19 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates `Slave::applyOperation()` to make it include the
> operation ID in operation statuses for operations that have an ID.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb 
> 
> 
> Diff: https://reviews.apache.org/r/66365/diff/1/
> 
> 
> Testing
> -------
> 
> Tests still pass on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message