mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66371: Temporarily disabled CSI proto compilation in CMake.
Date Fri, 30 Mar 2018 17:22:09 GMT


> On March 30, 2018, 10:02 a.m., David Forsythe wrote:
> > This works for me on FreeBSD now, though I'm not sure if it would be better to gate
this rather than removing it completely?

I remove it instead of gating it for the following reasons:

1. Current CMake doesn't include any build rules for the components (storage local resource
provider) that depends on CSI, so it doesn't matter if we compile the proto file. The rules
will be introduced in https://reviews.apache.org/r/66163/.
2. The compilation problem happens not only on FreeBSD, but also on platforms using GCC 7,
so there is no simple gate for this.
3. This is just a temporary removal. https://reviews.apache.org/r/65594/ will introduce a
internal proto message that uses a CSI message, so eventually we need CSI proto to be compiled
on all supported platforms, after the CSI bundle is bumped to 0.2 (where there will be no
name conflicts).

Therefore, it doesn't worth the time to design a gate that will be removed soon.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66371/#review200232
-----------------------------------------------------------


On March 29, 2018, 11:58 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66371/
> -----------------------------------------------------------
> 
> (Updated March 29, 2018, 11:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, David Forsythe, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8749
>     https://issues.apache.org/jira/browse/MESOS-8749
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `major` and `minor` macros defined on some systems conflict with
> field names in the CSI v0.1.0 spec proto. Temporarily disable it in
> CMake until CSI is bumped to 0.2.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt fb9e9d4cfc4a62830fe3065a139ae14401c0e52e 
> 
> 
> Diff: https://reviews.apache.org/r/66371/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` with CMake
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message