From reviews-return-75103-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 22 09:00:10 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A318217FB6 for ; Thu, 22 Mar 2018 09:00:10 +0000 (UTC) Received: (qmail 5184 invoked by uid 500); 22 Mar 2018 09:00:10 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 5142 invoked by uid 500); 22 Mar 2018 09:00:10 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 5125 invoked by uid 99); 22 Mar 2018 09:00:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2018 09:00:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3D348C0146; Thu, 22 Mar 2018 09:00:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GaOp1T1xV0Tm; Thu, 22 Mar 2018 09:00:08 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E53025FDE8; Thu, 22 Mar 2018 09:00:07 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7E271E0253; Thu, 22 Mar 2018 09:00:07 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 2AF17C40109; Thu, 22 Mar 2018 09:00:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8285109426210318839==" MIME-Version: 1.0 Subject: Re: Review Request 66207: Used native protobuf map in OCI v1 image spec. From: Mesos Reviewbot To: Chun-Hung Hsiao , Benjamin Mahler , Gilbert Song Cc: Mesos Reviewbot , Qian Zhang , mesos Date: Thu, 22 Mar 2018 09:00:06 -0000 Message-ID: <20180322090006.34434.37446@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66207/ X-Sender: Mesos Reviewbot References: <20180322065912.34434.9599@reviews-vm2.apache.org> In-Reply-To: <20180322065912.34434.9599@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============8285109426210318839== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66207/#review199745 ----------------------------------------------------------- Patch looks great! Reviews applied: [66206, 66207] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 22, 2018, 6:59 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66207/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 6:59 a.m.) > > > Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gilbert Song. > > > Bugs: MESOS-8702 > https://issues.apache.org/jira/browse/MESOS-8702 > > > Repository: mesos > > > Description > ------- > > Used native protobuf map in OCI v1 image spec. > > > Diffs > ----- > > include/mesos/oci/spec.proto f7f197909ebd5517941e063d8c80b0a7f745bb8d > src/oci/spec.cpp ad5b8bea54e000752c681a9bfd900b25a4158544 > src/tests/containerizer/oci_spec_tests.cpp f9a98f635327eb0896f8d9719c8be91e5b5c69d3 > > > Diff: https://reviews.apache.org/r/66207/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > > --===============8285109426210318839==--