From reviews-return-75419-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 29 18:45:58 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D854A1865A for ; Thu, 29 Mar 2018 18:45:58 +0000 (UTC) Received: (qmail 50151 invoked by uid 500); 29 Mar 2018 18:45:53 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 50120 invoked by uid 500); 29 Mar 2018 18:45:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 50105 invoked by uid 99); 29 Mar 2018 18:45:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2018 18:45:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AECE8180677; Thu, 29 Mar 2018 18:45:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id mAT3xGsy_6II; Thu, 29 Mar 2018 18:45:51 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4C8565F181; Thu, 29 Mar 2018 18:45:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 345CFE021B; Thu, 29 Mar 2018 18:45:49 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 478C3C40416; Thu, 29 Mar 2018 18:45:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0631442507125752398==" MIME-Version: 1.0 Subject: Re: Review Request 66362: Fixed use of const reference for storing an rvalue in a test. From: Mesos Reviewbot To: Greg Mann Cc: Mesos Reviewbot , Gaston Kleiman , mesos Date: Thu, 29 Mar 2018 18:45:48 -0000 Message-ID: <20180329184548.17038.52752@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66362/ X-Sender: Mesos Reviewbot References: <20180329171704.17038.92463@reviews-vm2.apache.org> In-Reply-To: <20180329171704.17038.92463@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============0631442507125752398== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66362/#review200207 ----------------------------------------------------------- Patch looks great! Reviews applied: [66362] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 29, 2018, 5:17 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66362/ > ----------------------------------------------------------- > > (Updated March 29, 2018, 5:17 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Fixed use of const reference for storing an rvalue in a test. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp 98b697d8f8f249b801f960dab9cef5958f920302 > > > Diff: https://reviews.apache.org/r/66362/diff/1/ > > > Testing > ------- > > Tests passed on Mesosphere's internal CI. > > > Thanks, > > Gaston Kleiman > > --===============0631442507125752398==--