mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 66958: Windows: Fixed inheritance in subprocess_windows.cpp.
Date Fri, 04 May 2018 17:20:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66958/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-8674
    https://issues.apache.org/jira/browse/MESOS-8674


Repository: mesos


Description
-------

subprocess_windows.cpp was creating inheritable pipes and files. On
Windows, our policy is to make everything not inheritable and then have
`CreateProcessW` set the the right pipes to be inheritable to avoid any
handle leaks. Now, subprocess_windows.cpp follows that inheritance
policy.


Diffs
-----

  3rdparty/libprocess/src/subprocess_windows.cpp a1e6425faff01f816748f0b8b5307612b6dd8302



Diff: https://reviews.apache.org/r/66958/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message