mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66962: Windows: Added tests for async IO functions.
Date Mon, 07 May 2018 21:05:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66962/#review202593
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 663 (patched)
<https://reviews.apache.org/r/66962/#comment284475>

    `s/os::getcwd()/sandbox`



3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 674-675 (patched)
<https://reviews.apache.org/r/66962/#comment284476>

    `s/ASSERT/EXPECT`



3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 686-687 (patched)
<https://reviews.apache.org/r/66962/#comment284477>

    Ditto.



3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 707-710 (patched)
<https://reviews.apache.org/r/66962/#comment284478>

    Ditto, and the other non-fatal ones.



3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 726-729 (patched)
<https://reviews.apache.org/r/66962/#comment284481>

    Nit: I can't remember indentation rules, did you run clang-format?



3rdparty/stout/tests/os/filesystem_tests.cpp
Lines 754-755 (patched)
<https://reviews.apache.org/r/66962/#comment284480>

    EXPECTs.


- Andrew Schwartzmeyer


On May 4, 2018, 10:27 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66962/
> -----------------------------------------------------------
> 
> (Updated May 4, 2018, 10:27 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670
>     https://issues.apache.org/jira/browse/MESOS-8670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> New asynchronous functions were introduced to the Windows stout read
> and write implementations, so eztra tests were added.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp b17ab9aaa94ae14b6707a9ac7a54b9db38615f2a

> 
> 
> Diff: https://reviews.apache.org/r/66962/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message