mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 66955: Windows: Added overlapped support to `os::read`.
Date Tue, 22 May 2018 22:40:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66955/
-----------------------------------------------------------

(Updated May 22, 2018, 10:40 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Changes
-------

Updated read with Andy's suggestions.


Bugs: MESOS-8670
    https://issues.apache.org/jira/browse/MESOS-8670


Repository: mesos


Description
-------

Added overlapped handle support to `os::read`. Now, `os::read` will do
a blocking read no matter the handle type. Also, `os::read_async` will
do an overlapped read on an overlapped handle.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/read.hpp e957da81e55867b260d356f035d98918b85d1965



Diff: https://reviews.apache.org/r/66955/diff/2/

Changes: https://reviews.apache.org/r/66955/diff/1-2/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message