mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 66961: Windows: Ported sendfile_tests.cpp.
Date Tue, 22 May 2018 22:54:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66961/
-----------------------------------------------------------

(Updated May 22, 2018, 10:54 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Changes
-------

Addressed feedback.


Bugs: MESOS-3444 and MESOS-8681
    https://issues.apache.org/jira/browse/MESOS-3444
    https://issues.apache.org/jira/browse/MESOS-8681


Repository: mesos


Description (updated)
-------

The sendfile tests were using socketpair, but the rest of the tests
were crossplatform. By providing a Windows socketpair implementations,
the tests are now ported.


Diffs (updated)
-----

  3rdparty/stout/tests/CMakeLists.txt 43c5e873a3a3b8f79f0f888a450e186c6123d938 
  3rdparty/stout/tests/os/sendfile_tests.cpp 05966ae067ae3972598da3370eb16fdce5736c21 


Diff: https://reviews.apache.org/r/66961/diff/2/

Changes: https://reviews.apache.org/r/66961/diff/1-2/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message