mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 67356: Made `TestContainerizerProcess::launch()` thread safe.
Date Tue, 29 May 2018 14:21:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67356/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent huang, Ilya Pronin,
and James Peach.


Bugs: MESOS-3475
    https://issues.apache.org/jira/browse/MESOS-3475


Repository: mesos


Description
-------

This patch removes `os::setenv()`, `os::unsetenv()` calls that are
currently used to implicitly configure both `MesosExecutorDriver` and
v1 Executor via global environment variables. This change prepares a
map containing modified environment and passes it to a constructor of
an executor.


Diffs
-----

  src/tests/containerizer.cpp c4e18b7c5d6937f53f806e94a40c969cdcac79eb 
  src/tests/mesos.hpp 733344a2f07ebd9d841a55fb9bbfda2e3c1a1eb2 


Diff: https://reviews.apache.org/r/67356/diff/1/


Testing
-------

internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message