mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 67388: Moved: `io::internal::read/write` to separate file.
Date Wed, 30 May 2018 18:55:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67388/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-8668
    https://issues.apache.org/jira/browse/MESOS-8668


Repository: mesos


Description
-------

The implementation in `io::internal::read/write` uses `io::poll`, which
is UNIX specific. The Windows IOCP implementation will not use a
polling function, since there no unified mechanism, so the functions
have been moved to their own file.


Diffs
-----

  3rdparty/libprocess/Makefile.am d434001fbc49d337b6e29f6ac8c9c7475922a819 
  3rdparty/libprocess/src/CMakeLists.txt cf443dffd0663ecf02b7efd6f7094175b94aae19 
  3rdparty/libprocess/src/io.cpp 97f2b17092fbd23528cf3220fee5927a1ec38aba 
  3rdparty/libprocess/src/io_internal.hpp PRE-CREATION 
  3rdparty/libprocess/src/poll_io.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67388/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message