mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.
Date Fri, 08 Jun 2018 01:21:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67157/
-----------------------------------------------------------

(Updated June 8, 2018, 1:21 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao Li.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-8924
    https://issues.apache.org/jira/browse/MESOS-8924


Repository: mesos


Description
-------

The refactoring does the following things:
1. Manage the gRPC completion queue and the looper thread in the runtime
   process to get rid of a lock in `Runtime::Data`.
2. Move the computation of sending a request into the runtime process.
3. Let libprocess manage the runtime process automatically instead of
   managing its lifecycle in `Runtime::Data`.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/grpc.hpp cf165f0ca1fe3f4abea9117024ac97c25f6f31dc 
  3rdparty/libprocess/src/grpc.cpp a80bcb614ec96d92d21bc88a281d3208e86141a0 


Diff: https://reviews.apache.org/r/67157/diff/5/

Changes: https://reviews.apache.org/r/67157/diff/4-5/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message