mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67384: Windows: Made socket `int_fd` castable to `HANDLE` type.
Date Fri, 08 Jun 2018 17:29:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67384/#review204496
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/os/windows/fd.hpp
Line 151 (original), 151 (patched)
<https://reviews.apache.org/r/67384/#comment286971>

    This makes me want to mark these conversion ops as explicit even more...



3rdparty/stout/include/stout/os/windows/fd.hpp
Line 153 (original), 153-155 (patched)
<https://reviews.apache.org/r/67384/#comment286973>

    We should at least leave a NOTE as to why this is valid and necessary.


- Andrew Schwartzmeyer


On May 30, 2018, 11:39 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67384/
> -----------------------------------------------------------
> 
> (Updated May 30, 2018, 11:39 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8668
>     https://issues.apache.org/jira/browse/MESOS-8668
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Many Win32 functions that take in `HANDLE` also work on `SOCKET`, such
> as `ReadFile` or `CreateIoCompletionPort`. IOCP on Windows uses the
> `HANDLE` type uniformly, so we need to be able to convert socket
> `int_fd` to `HANDLE`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 5dbdff2680370d123579c5e3fdd9b0e0adaf512e

> 
> 
> Diff: https://reviews.apache.org/r/67384/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message